Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Fix dropping all labels #943

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Fix dropping all labels #943

merged 2 commits into from
Sep 1, 2020

Conversation

icco
Copy link
Contributor

@icco icco commented Sep 1, 2020

Proposed Changes

  • We were accidentally dropping all stackdriver labels due to a bug.

Release Note

Reenables sending of stackdriver metrics.

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Sep 1, 2020
@google-oss-robot google-oss-robot added approved Auto: added by prow when enough reviewers approve. size/M Auto: Medium number of changes. labels Sep 1, 2020
@sethvargo
Copy link
Member

/lgtm
/approve

Do we need to bump and cut a release of the verification server too then?

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Sep 1, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icco, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@icco
Copy link
Contributor Author

icco commented Sep 1, 2020

/lgtm
/approve

Do we need to bump and cut a release of the verification server too then?

sadly yes.

@google-oss-robot google-oss-robot merged commit c75b1e7 into google:main Sep 1, 2020
@icco icco deleted the sdddd branch September 1, 2020 20:07
@icco icco mentioned this pull request Sep 1, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

@whaught whaught Awaiting requested review from whaught

Assignees

@sethvargo sethvargo

Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/M Auto: Medium number of changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icco @sethvargo @google-oss-robot