Introduce command-line flag -XepAllSuggestionsAsWarnings
#3957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_538605260
branch
from
25fed4b to
af12364
Compare
|
@cushon it would be nice to add this flag to the documentation of the flags. Can you look into this? (I would open a PR if I could 😬) |
|
@rickie I'll try to take a look at it. The content of the packages is under the |
|
Okay clear, I can take a look in that case! 😄 |
|
Filed the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce command-line flag
-XepAllSuggestionsAsWarningsThis enables users that build with
-Werrorto disallow violations of customSUGGESTION-level bug patterns.Fixes #3301
FUTURE_COPYBARA_INTEGRATE_REVIEW=#3301 from PicnicSupermarket:rossendrijver/suggestions_as_warnings 5cd3aa1