Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak Travis build #1153

Closed
wants to merge 1 commit into from
Closed

Unbreak Travis build #1153

wants to merge 1 commit into from

Conversation

eaftan
Copy link
Contributor

@eaftan eaftan commented Oct 19, 2018

No description provided.

@Stephan202
Copy link
Contributor

There's a comment thread related to the openjdk10 build failure. In this particular case the issue is triggered when attempting to download junit:junit:jar:4.13-SNAPSHOT from the Sonatype Nexus Snapshots repository.

(Just leaving this comment here in case others building on top of Error Prone hit the same issue. But this may be a good opportunity to ask: are there plans to replace that SNAPSHOT dependency with a released artifact?)

@cushon
Copy link
Collaborator

cushon commented Nov 2, 2018

@Stephan202 thanks--I think we're seeing the same issue. I'm testing a work-around in #1162.

are there plans to replace that SNAPSHOT dependency with a released artifact?

junit-team/junit4#1496 :)

@cushon
Copy link
Collaborator

cushon commented Nov 2, 2018

I fixed it in 7afde3e.

@cushon cushon closed this Nov 2, 2018
@Stephan202
Copy link
Contributor

@cushon hah, feeling your pain; I opened a post-4.12 PR nearly four years ago (junit-team/junit4#1054) :).

(But at this point Google may consider migrating to the more active JUnit 5 development?)

@cpovirk cpovirk deleted the unbreak-travis branch August 20, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants