Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link styles: follow recommended practice and underline by default #1815

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 2, 2024

Preview, e.g.: https://deploy-preview-1815--docsydocs.netlify.app/docs/


Projects that wish to preserve Docsy's old behavior can add the following to their assets/scss/_variables_project.scss, among other ways:

$link-decoration: none !default;

@chalin chalin requested review from emckean, LisaFC and deining February 2, 2024 13:52
@chalin chalin force-pushed the chalin-im-underline-2024-02-02 branch from ea4805b to 7bc4024 Compare February 2, 2024 13:56
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine for me.

@chalin chalin force-pushed the chalin-im-underline-2024-02-02 branch from a95cb58 to 307f723 Compare February 2, 2024 14:23
@chalin chalin merged commit 33aa253 into google:main Feb 2, 2024
11 checks passed
@chalin chalin deleted the chalin-im-underline-2024-02-02 branch February 2, 2024 14:35
mtardy added a commit to cilium/tetragon that referenced this pull request May 31, 2024
See more details in google/docsy#1815.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy added a commit to cilium/tetragon that referenced this pull request May 31, 2024
See more details in google/docsy#1815.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
mtardy added a commit to cilium/tetragon that referenced this pull request Jun 3, 2024
See more details in google/docsy#1815.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Bootstrap's default link style, which is recommended
2 participants