Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default symbol visibility to hidden except for JNI methods. #26

Merged
merged 1 commit into from
Jan 10, 2017
Merged

Set default symbol visibility to hidden except for JNI methods. #26

merged 1 commit into from
Jan 10, 2017

Conversation

nmittler
Copy link
Contributor

@nmittler nmittler commented Jan 9, 2017

No description provided.

@nmittler nmittler requested a review from kruton January 9, 2017 22:19
kruton
kruton suggested changes Jan 10, 2017
View reviewed changes
Copy link
Contributor

@kruton kruton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing should be marked public/exported except for the JNI_OnLoad functions.

@nmittler
Copy link
Contributor Author

@kruton PTAL

@nmittler nmittler merged commit 4f47590 into google:master Jan 10, 2017
@ArchanaPrabhu ArchanaPrabhu mentioned this pull request Apr 26, 2023
Open
@JasonZhao0608 JasonZhao0608 mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruton kruton kruton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmittler @kruton