Add formatting checks to Travis-CI #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruton
force-pushed
the
travis-ci-clang-format
branch
from
1a74769 to
4fedd8b
Compare
kruton
commented
Dec 27, 2016
| @@ -59,6 +71,8 @@ android: | |||
| - 'android-sdk-license-.+' | |||
|
|
|||
| script: | |||
| - git rev-list $(git merge-base HEAD origin/master)..HEAD | xargs -i git clang-format --binary=$(which clang-format-3.8) --style=file {} && git diff --exit-code || { git reset --hard; false; } | |||
| - git rev-list $(git merge-base HEAD origin/master)..HEAD | xargs -i git diff-tree --no-commit-id --name-only -r {} | grep -E '\.java$' | xargs -r git ls-files | xargs -r java -jar $HOME/gjf.jar -a -i --fix-imports-only && git diff --exit-code || { git reset --hard; false; } | |||
There was a problem hiding this comment.
This seems like it should logically work, but I got some weird results when I didn't have this rebased.
nmittler
approved these changes
Dec 27, 2016
kruton
force-pushed
the
travis-ci-clang-format
branch
from
7707e0e to
ee3b7ff
Compare
This mirrors what the Android source tree used to have as presubmit checks. It uses clang-format for formatting C++ and Java files, but google-java-format for checking for unused imports and import ordering.
kruton
force-pushed
the
travis-ci-clang-format
branch
from
ee3b7ff to
4b58bfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors what the Android source tree used to have as presubmit
checks. It uses clang-format for formatting C++ and Java files, but
google-java-format for checking for unused imports and import ordering.