Various changes toward building on windows #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next issue after this: poll is not supported.
kruton
reviewed
Dec 22, 2016
| @@ -29,7 +29,12 @@ | |||
|
|
|||
| #define LOG_TAG "NativeCrypto" | |||
|
|
|||
| #include <arpa/inet.h> | |||
| #ifdef _WIN32 | |||
| #include <Winsock2.h> | |||
There was a problem hiding this comment.
This should be lowercase in case we compile against MinGW which is usually compiled with case-sensitive filesystems.
kruton
reviewed
Dec 22, 2016
| visualCpp(VisualCpp) { | ||
| // Temporary hack for https://github.com/gradle/gradle/issues/929 | ||
| installDir "C:/Program Files (x86)/Microsoft Visual Studio 14.0" | ||
| windowsSdkDir "C:/Program Files (x86)/Microsoft SDKs/Windows/v7.1A" |
There was a problem hiding this comment.
these have to be in this format:
file:///C:/Program%20Files%20(x86)/...
kruton
reviewed
Dec 22, 2016
| @@ -22,8 +22,8 @@ subprojects { | |||
| toolChains { | |||
| visualCpp(VisualCpp) { | |||
| // Temporary hack for https://github.com/gradle/gradle/issues/929 | |||
| installDir "C:/Program Files (x86)/Microsoft Visual Studio 14.0" | |||
| windowsSdkDir "C:/Program Files (x86)/Microsoft SDKs/Windows/v7.1A" | |||
| installDir "file:///C:/Program%20Files%20(x86)/Microsoft%20Visual Studio 14.0" | |||
|
@kruton PTAL |
kruton
approved these changes
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next issue after this: poll is not supported.