Add a picture to Rc #2583
Add a picture to Rc #2583
Conversation
src/smart-pointers/rc.md
Outdated
| : : : : | ||
| : +-----+ : : +-------------+-----------+ : | ||
| : a: | o---|---:-----:-->| strong: 2 | weak: 0 | : | ||
| : +-----+ : : +-------------+-----------+ : |
There was a problem hiding this comment.
Is there a way to use an "upside-down T" (or "bottom", as us logicians call it) at the lower end of the line separating the "strong" and "weak" cells?
There was a problem hiding this comment.
Good idea - that is an ugly cross! But I tweaked it a bit -- WDYT?
src/smart-pointers/rc.md
Outdated
| .- - - - - - - -. .- - - - - - - - - - - - - - - - -. | ||
| : : : : | ||
| : +-----+ : : +-------------+-----------+ : | ||
| : a: | o---|---:-----:-->| strong: 2 | weak: 0 | : |
There was a problem hiding this comment.
Why not make it weak: 2 and say that every strong reference is also considered a weak reference. Or just leave this slight "lie". I don't think people taking this course need this level of detail to be correct.
There was a problem hiding this comment.
I just omitted the "weak" bit -- that can remain an implementation detail :)
|
Thanks for this change--I was teaching this slide recently and wished I had a diagram instead of describing the memory layout of |
I suppose my
svgbobskills leave a bit to be desired, but I think the meaning is clear:Now that I look through the
Rcimplementation, there's a weak count for every strong count, so theweak: 0here is inaccurate. But, maybe this is too much of an implementation detail? Should I just concentrate on strong refs? I suppose I could put a...in that upper-right box, to suggest there's more going on here?