Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove speaker note on "runtime evaluated constants" #2555

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Remove speaker note on "runtime evaluated constants" #2555

merged 1 commit into from
Jan 16, 2025

Conversation

djmitche
Copy link
Collaborator

It's unclear what this would mean! It was introduced in 89ddb2c.

@djmitche
Remove speaker note on "runtime evaluated constants"
e65fa1b 
It's unclear what this would mean! It was introduced in 89ddb2c.
@djmitche djmitche enabled auto-merge (squash) January 16, 2025 08:50
mgeisler
mgeisler approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, happy to trim this. I think it refers to a constant with a OnceCell.

@djmitche djmitche merged commit 5f447b4 into google:main Jan 16, 2025
35 checks passed
@djmitche
Copy link
Collaborator Author

Oh, I will make a note to add some content on that topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgeisler mgeisler mgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djmitche @mgeisler