Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Exercise: method and traits: change output" #2548

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

Alx-Lai
Copy link
Collaborator

@Alx-Lai Alx-Lai commented Jan 14, 2025

Reverts #2383

Since #2397 is merged, to align the goal in #2478, rollback this temp workaround.

@mgeisler
Copy link
Collaborator

Oh, this fails because of an unrelated timeout:

[0-1] Error in "Playground.executes the hello world code and prints the hello message"
Error: Expect  to have text

Expected: StringContaining "🌍"
Received: "The operation timed out: deadline has elapsed"
    at Context.<anonymous> (/home/runner/work/comprehensive-rust/comprehensive-rust/tests/src/playground.test.ts:[30](https://github.com/google/comprehensive-rust/actions/runs/12767680980/job/35586546795?pr=2548#step:15:31):37)
[0-1] Error in "Playground.shows error messages in stderr if the code is broken"
Error: Expect $(`code.result.stderr`) to be displayed

The new JS test is from #2513 (cc @michael-kerscher). We might need to disable it for now if it turns out to be flaky.

@mgeisler mgeisler mentioned this pull request Jan 14, 2025
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for remembering this!

@Alx-Lai Alx-Lai enabled auto-merge (squash) January 14, 2025 16:55
@Alx-Lai Alx-Lai disabled auto-merge January 14, 2025 16:56
@Alx-Lai Alx-Lai enabled auto-merge (squash) January 14, 2025 16:56
@mgeisler mgeisler closed this Jan 15, 2025
auto-merge was automatically disabled January 15, 2025 09:54

Pull request was closed

@mgeisler mgeisler reopened this Jan 15, 2025
@mgeisler
Copy link
Collaborator

Closing and reopening the PR is an easy way to re-trigger the tests. The unrelated failure should be fixed by #2551.

@mgeisler mgeisler enabled auto-merge (squash) January 15, 2025 09:55
@mgeisler mgeisler merged commit aa548f4 into main Jan 15, 2025
70 of 71 checks passed
@mgeisler mgeisler deleted the revert-2383-main branch January 15, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants