Fix a few accessibility violations #2547
Conversation
henrif75
commented
Jan 14, 2025
henrif75
commented
- Add chrome.css and general.css to override default css file. This is necessary to fix links without underline (hyperlinks relying only on color).
- Fix pop-out button without id and wrong ARIA-ROLE
- Speaker's notes now at correct heading sequence (H3)
- Speaker's notes now at correct heading sequence - Add chrome.css and general.css to override default css file. This is necessary to fix links without underline violation (hyperlinks relying only on color)
| @@ -0,0 +1,279 @@ | |||
| /* Base styles and content styles */ | |||
There was a problem hiding this comment.
It's strange that we've been missing it all along 😄
My understanding is that mdbook build will pull in theme files from https://github.com/rust-lang/mdBook/tree/master/src/theme/css, unless the local theme has a file with the same name.
But perhaps I've misunderstood this all along?
| @@ -289,7 +289,6 @@ | |||
|
|
|||
| <!-- Apply ARIA attributes after the sidebar and the sidebar toggle button are added to the DOM --> | |||
| <script> | |||
| document.getElementById('sidebar-toggle').setAttribute('aria-expanded', sidebar === 'visible'); | |||
There was a problem hiding this comment.
Does this change perhaps belong in https://github.com/rust-lang/mdBook/blob/master/src/theme/index.hbs?
|
Thanks so much for looking at this, Henri! |
I thought missing files were pulled in automatically from the basic theme. Loading the page with the inspector open shows
So I think the files were copied correctly already. |
FWIW, if any of the CSS files (e.g., |
