Fix missing images and Arabic fonts in course PDFs #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-heller
force-pushed
the
upgrade-mdbook-pandoc
branch
from
be8d2d7 to
de4656c
Compare
max-heller
changed the title
- Fixes missing images in PDFs (those specified as <img> elements) - Configures Arabic fonts
max-heller
force-pushed
the
upgrade-mdbook-pandoc
branch
from
de4656c to
eec4af0
Compare
mgeisler
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's give #2531 another try
The fix for the Persian translation issue, if you're curious.