Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ru: translate days 1-2 section titles #1973

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

1dimir
Copy link
Contributor

@1dimir 1dimir commented Apr 11, 2024

  • Add translations for the new extracted messages related to Day 1and Day 2 chapters;
  • Fix numbering in translation of Day 4 titles;
  • Use PO file translator comments for notes and reasons why one or another choice was made, mention alternatives;
  • Do not translate type and trait names;
  • Rename: Поток управления -> Управляющие конструкции;
  • Rename: Перечисления и сопоставление с образцом. -> Деструктуризация;
  • Rename: Ссылки -> Заимствование;
  • Rename: Висячие ссылки -> Изменяемые ссылки;
  • Rename: Вторая половина дня -> После обеда;
  • Rename: Поток управления -> Let в потоке управления (src: Let Control Flow);
  • Rename: Функции -> Обобщённые функции (src: Generic Functions);
  • Rename: Обобщения (generics). -> Обобщённые типажи (src: Generic Traits);
  • Cannot translate Slices: &[T] - possible bug

#326

1dimir and others added 4 commits April 8, 2024 00:36
* Add translations for new extracted messages related to Day 1 chapter;
* Fix numbering of Day 4 titles;
* Heavily use PO file translator comments for notes and reasons why one or another choice was made, mention alternatives;
* Rename: Поток управления -> Управляющие конструкции;
* Rename: Перечисления и сопоставление с образцом. -> Деструктуризация;
* Rename: Ссылки -> Заимствование;
* Rename: Висячие ссылки -> Изменяемые ссылки;
* Rename: Вторая половина дня -> После обеда;
* Cannot translate `Slices: &[T]`: there must be a bug with no message id for the nav item (TODO: reproduce & localize);
* Add translations for new extracted messages related to Day 2 morning chapter;
* Rename: Поток управления -> `Let` в потоке управления (Let Control Flow);
* Rename: Функции -> Обобщённые функции (Generic Functions);
* Rename: Обобщения (generics). -> Обобщённые типажи (Generic Traits);
* Add translations for the new extracted messages related to Day 2 Afternoon;
* Do not translate type and trait names;
@1dimir
Copy link
Contributor Author

1dimir commented Apr 11, 2024

I'm looking into failed dprint check.

* Ensure translator comments come before references
@1dimir
Copy link
Contributor Author

1dimir commented Apr 11, 2024

I'm looking into failed dprint check.

Resolved

po/ru.po Show resolved Hide resolved
po/ru.po Show resolved Hide resolved
Copy link
Collaborator

@dyeroshenko dyeroshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: For future PRs, can we try to have 1-2 commits per PR? It's just more convenient to review smaller changes.

Other than that, LGTM and huge thank you!

@dyeroshenko dyeroshenko merged commit b76af9c into google:main Apr 16, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants