-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused method traverseEs6 #2892
Comments
Ah sorry. We usually do keep it around for one version but I forgot to do it in this case. Would using one the "snapshot" builds from https://oss.sonatype.org/content/repositories/snapshots/com/google/javascript/closure-compiler/1.0-SNAPSHOT/ help? |
The problem I have is that removing this function breaks backward compatibility. Sometimes my users prefer to stick to specific versions because upgrading breaks their build (eg. #2822). |
Yeah, we'll put it back, at least for one release. My bad. |
… Java API. Fixes google#2892 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=193228792
fee5195
Removes the
NodeTraversal.traverseEs6
static function which I guess got refactored to beNodeTraversal.traverse
now (which it also delegates to). I'm using it some shadow-cljs utility passes.Please consider keeping the
NodeTraversal.traverseEs6
function around for a few versions since it creates unnecessary breakage otherwise. I will update my code but can't becauseNodeTraversal.traverse
is not available yet.Just removing the function without deprecating it first (it isn't deprecated in 20180402) makes upgrading a bit painful.
The text was updated successfully, but these errors were encountered: