Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to etcdiscover tool #948

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

mhutchinson
Copy link
Contributor

This was removed in trillian#2376. If this has value to anyone then it would be great to take a pull request to add this back. In the meantime, this at least removes dead references.

This was removed in trillian#2376. If this has value to anyone then it would be great to take a pull request to add this back. In the meantime, this at least removes dead references.
@mhutchinson mhutchinson requested a review from a team as a code owner June 17, 2022 15:35
@mhutchinson mhutchinson requested review from roger2hk and AlCutter and removed request for a team June 17, 2022 15:35
@roger2hk
Copy link
Contributor

I find some more references to etcdiscover tool in this repo. See if you would like to remove them in this PR as well.

@mhutchinson
Copy link
Contributor Author

@roger2hk thanks. updated these references.

Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have got a question about the ${prom_cfg}. LGTM for the rest.

trillian/integration/ct_functions.sh Outdated Show resolved Hide resolved
trillian/integration/ct_functions.sh Outdated Show resolved Hide resolved
@roger2hk roger2hk merged commit 1a8898f into google:master Jun 20, 2022
@mhutchinson mhutchinson deleted the noetcdiscover branch January 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants