Add IssuanceChainStorage PostgreSQL implementation #1618
Conversation
|
/gcbrun |
robstradling
force-pushed
the
postgresql_storage_saving
branch
from
8bd62f4 to
f350391
Compare
|
/gcbrun |
|
/gcbrun |
|
The Cloud Build step 3 (ci-ready) failed because the hostname changed to |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
There was a problem hiding this comment.
given that the only diff between this file and the original ones is ctfe_storage_connection_string:, I wonder whether we could automatically generate them. No need to take action now.
There was a problem hiding this comment.
I'd wondered about locally editing them (e.g., with sed) in the Cloud Build script, but @roger2hk wasn't keen on that approach. We settled on duplicating the config files but avoiding duplicating the trillian/integration/ct_functions.sh script.
There was a problem hiding this comment.
We can have a script to generate that but I still want to have the generated config file(s) checked into the repository. This is similar to the generated protobuf files.
|
Looks good to me, a few nits that can be handled later on - just one question as I'm not very familiar with PostgreSQL: there's no need to do anything special around STRICT mode, right? PostgreSQL handles it by always enforcing "strict mode" server side? I'll let @roger2hk provide more insights as he's the author of the original mysql deduplication code. |
|
Thanks for the review, @phbnf! PostgreSQL doesn't have an equivalent of MySQL's "strict mode"; so yeah, it's "strict" by default. |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
This reverts commit fa3dbdb.
|
/gcbrun |
|
/gcbrun |
This PR is based on the existing IssuanceChainStorage MySQL implementation. The first several commits were auto-generated by this script, which forked the existing MySQL code into a different directory (whilst preserving the git history) and then searched'n'replaced "MySQL" to "PostgreSQL".
Checklist