Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the missing exit code when go test is failed in presubmit script #1008

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Fix the missing exit code when go test is failed in presubmit script #1008

merged 2 commits into from
Dec 11, 2022

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Nov 30, 2022 •
edited
Loading

The certificate-transparency-go-cloud-build-pull-request (trillian-opensource-ci) is successfully even the build is failed.

Step #4 - "default_test": FAIL	github.com/google/certificate-transparency-go/submission [build failed]

--no-generate is added to the PRESUBMIT_OPTS to avoid the generated files are being removed and regenerated during the concurrent tests.

The rate limit threshold is increased from 1.01 to 2 to bypass the flakiness in fixchain/ratelimiter/limiter_test.go.

Checklist

@roger2hk roger2hk requested a review from pphaneuf November 30, 2022 14:15
@roger2hk roger2hk closed this Nov 30, 2022
@roger2hk roger2hk force-pushed the fix-missing-go-test branch from 2538508 to daa89b7 Compare November 30, 2022 16:30
@roger2hk roger2hk reopened this Nov 30, 2022
@roger2hk roger2hk changed the title Add the missing go test in presubmit script Fix the missing exit code when go test is failed in presubmit script Nov 30, 2022
@roger2hk roger2hk force-pushed the fix-missing-go-test branch 3 times, most recently from 933cdf1 to 7e09625 Compare December 2, 2022 09:01
@roger2hk roger2hk requested a review from AlCutter December 2, 2022 09:23
@roger2hk roger2hk marked this pull request as ready for review December 2, 2022 09:23
@roger2hk roger2hk requested a review from a team as a code owner December 2, 2022 09:23
AlCutter
AlCutter approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the golangci bit which I think possibly snuck in here by mistake :)

.golangci.yaml Show resolved Hide resolved
@roger2hk roger2hk force-pushed the fix-missing-go-test branch from f265a82 to 7dfcc67 Compare December 9, 2022 06:13
@roger2hk roger2hk force-pushed the fix-missing-go-test branch from 7dfcc67 to 7f69303 Compare December 11, 2022 21:53
@roger2hk roger2hk merged commit 46b3305 into google:master Dec 11, 2022
@roger2hk roger2hk deleted the fix-missing-go-test branch December 11, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

@pphaneuf pphaneuf Awaiting requested review from pphaneuf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roger2hk @AlCutter