Dispatcher refactor to improve function declaration, definition, and extension #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a top-level
cel.Type
as well as functional options for configuringcel.Variable
andcel.Function
definitions using go-native APIs.This change is a shift away from the existing protobuf APIs which is also provides the following improvements:
The only drawback of this approach is that there is some minimal invocation overhead for functions declared/defined in this manner. Future optimizations may permit users to disable such type-guards if they deem them not to be necessary.
As a follow up PR, the
ext
function libraries and CEL standard operators will be shifted over to this new declaration style to improve the ease of extension of the core library implementations.This is the basis for the feature requested in #493