Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the recursion depth is being checked during parser AST visit #542

Merged
merged 1 commit into from
May 19, 2022

Conversation

TristonianJones
Copy link
Collaborator

Parser recursion limits were previously only being checked during ANTLR rule entry / exit,
but this does not adequately protect against the construction of deeply recursive ASTs.

The C++ implementation enforces recursion limiting during AST visit calls, and so Go now
will do the same.

Closes #541

@TristonianJones TristonianJones requested a review from jcking May 18, 2022 07:49
@TristonianJones TristonianJones merged commit d5bdc27 into google:master May 19, 2022
@TristonianJones TristonianJones deleted the parser-recursion-fix branch May 19, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSS-Fuzz issue 47450
2 participants