Fix the occurs check to prevent tagging types as substitutions for themselves #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcking
reviewed
May 13, 2022
TristonianJones
force-pushed
the
occur-check-cycle-fix
branch
from
91aec9d to
434b5f3
Compare
jcking
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two locations where a type parameter can get accidentally tagged as a substitution for itself. The original code caught one location, and the code since https://github.com/google/cel-go/releases/tag/v0.11.1 caught a different one.
This change catches the problematic tagging at both locations, thus avoiding a stack overflow when a type is marked
as a substitution of itself.