Option to configure CEL via env.Config object #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l46kok
previously approved these changes
Feb 14, 2025
TristonianJones
force-pushed
the
describe-env-3
branch
from
2a5ae83 to
f4cee07
Compare
l46kok
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnvOption to configure CEL via Config object
Introduces validation methods and checks on all env exposed classes,
specifically
env.Config.Validate()is called before processing any configobject within the
cel.FromConfig()option.This change also introduces limitations on how an environment can be
constructed when being used with standard library subsetting ... any
singleton library which is being subset must be subset at the time it is
configured. Any subsequent attempt to configure the singleton will either
be ignored or result in an error. The
FromConfigoption validates collisionswithin the pre-existing config, but there is no subsequent validation
afterwards.