Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to configure CEL via env.Config object #1129

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

TristonianJones
Copy link
Collaborator

@TristonianJones TristonianJones commented Feb 13, 2025

EnvOption to configure CEL via Config object

Introduces validation methods and checks on all env exposed classes,
specifically env.Config.Validate() is called before processing any config
object within the cel.FromConfig() option.

This change also introduces limitations on how an environment can be
constructed when being used with standard library subsetting ... any
singleton library which is being subset must be subset at the time it is
configured. Any subsequent attempt to configure the singleton will either
be ignored or result in an error. The FromConfig option validates collisions
within the pre-existing config, but there is no subsequent validation
afterwards.

l46kok
l46kok previously approved these changes Feb 14, 2025
@TristonianJones TristonianJones merged commit 4b27149 into google:master Feb 14, 2025
2 checks passed
@TristonianJones TristonianJones deleted the describe-env-3 branch February 14, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants