Fix a crash in mismatched output check for nested rules #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seirl
force-pushed
the
fix_output_match_crash
branch
2 times, most recently
from
bf2f3c1 to
5bcce86
Compare
Minimal repro:
rule:
match:
- condition: "1 < 0"
output: "true"
- condition: "1 > 0"
rule:
match:
- output: "'false'"
This would segfault the Policy Compiler, because it would try to access
`.Output().SourceID()` of the second block to log an error, but
`.Output()` is nil for nested rules.
seirl
force-pushed
the
fix_output_match_crash
branch
from
5bcce86 to
e0e5c50
Compare
TristonianJones
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal repro:
This would segfault the Policy Compiler, because it would try to access
.Output().SourceID()of the second block to log an error, but.Output()is nil for nested rules.