Fix features selection, broken by #478 #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently many things fail to build due to google#478 stripping out all the features.
It works properly with no explicit targets set (aka "use all the targets"), and it also works properly with some of the examples that set `default-members = []`. I think there's still something wrong, because it dropped features from some Windows-specific crates relative to before google#478, but I'm not sure what's supposed to happen. At least all the tests in this repository pass on Linux again...
bsilver8192
requested review from
dfreese,
UebelAndre,
illicitonion and
acmcarther
as code owners
|
@sayrer FYI, if you want to take a look. |
It doesn't work any more, now that I changed the code to only use supported targets.
bsilver8192
added a commit
to bsilver8192/cargo-raze
that referenced
this pull request
Sep 16, 2022
This is how I work around rust-lang/cargo#5042 to get path dependencies into vendored Rust dependencies. The generated BUILD files are built with google#524, because otherwise they don't work. This fixes google#361.
dae
added a commit
to ankitects/anki
that referenced
this pull request
Sep 25, 2022
Latest rules_rust now requires them. Can't use the 0.16 release due to not-yet-merged google/cargo-raze#524
|
I believe this fixes the issue outlined in #530. Thanks a bunch for working on this and fixing it! |
|
@dfreese is there any chance this change could be included in a patch/minor release? If this fixes the issue, it would be a huge unblocker for our repo |
|
@dfreese @illicitonion @acmcarther could one of you review this and release v0.16.1? |
PiotrSikora
approved these changes
Nov 21, 2022
|
@sayrer Please could you give this a look? |
dfreese
approved these changes
Nov 25, 2022
|
published 0.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works properly with no explicit targets set (aka "use all the
targets"), and it also works properly with some of the examples that set
default-members = [].I think there's still something wrong, because it dropped features from
some Windows-specific crates relative to before #478, but I'm not sure
what's supposed to happen. At least all the tests in this repository
pass on Linux again...