Testing bazel-based build breakage with upstream rules_rust #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreese
requested review from
UebelAndre,
illicitonion and
acmcarther
as code owners
added 3 commits
May 6, 2022 06:01
This reverts commit d4e10e1.
|
@UebelAndre, in attempting to track down some of the errors in #482, it looks like cargo no longer gets pulled in automatically after bumping the version of rules_rust. I'm assuming that was an intentional change upstream. Before I splunk too much further, is the appropriate fix on that obvious to you? |
|
Looks like the breaking change was bazelbuild/rules_rust#1079, which flipped incompatible_disable_custom_test_launcher. |
dfreese
changed the title
|
I'm so sorry, I don't know how I missed this issue! I think all that's needed is for the tests to explicitly handle making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.