Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix TCPRcvCollapsed comment #3550

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

0x0034
Copy link
Contributor

@0x0034 0x0034 commented Jun 21, 2024

Hi, this commit only modify the code comments without making any logical changes.

Copy link

google-cla bot commented Jun 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @0x0034. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@0x0034 0x0034 force-pushed the doc/fixTCPRcvCollapsedComment branch from 8386304 to 973f268 Compare June 21, 2024 03:17
@iwankgb
Copy link
Collaborator

iwankgb commented Jun 22, 2024

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 22, 2024

/retest

1 similar comment
@0x0034
Copy link
Contributor Author

0x0034 commented Jun 24, 2024

/retest

@0x0034
Copy link
Contributor Author

0x0034 commented Jun 24, 2024

It looks like there is something wrong with e2e's environment preparation. Is there anything i can do ?

@0x0034
Copy link
Contributor Author

0x0034 commented Jun 24, 2024

/retest-required

@iwankgb
Copy link
Collaborator

iwankgb commented Jun 28, 2024

/retest

@iwankgb iwankgb merged commit 89f779d into google:master Jun 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants