Remove mentions of accelerator from the docs #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was removed in google#3206.
|
Hi @bobrik. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
iwankgb
approved these changes
Jan 21, 2024
|
while working on rebasing #3420 I noticed this PR added metrics that do not exist: |
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Mar 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/google/cadvisor](https://togithub.com/google/cadvisor) | `v0.48.1` -> `v0.49.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/cadvisor (github.com/google/cadvisor)</summary> ### [`v0.49.1`](https://togithub.com/google/cadvisor/releases/tag/v0.49.1) [Compare Source](https://togithub.com/google/cadvisor/compare/v0.49.0...v0.49.1) #### What's Changed - Cherrpick [#​3485](https://togithub.com/google/cadvisor/issues/3485) to release-v0.49- Remove s390x support by [@​bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3486](https://togithub.com/google/cadvisor/pull/3486) - build docker - add --provenance=false flag by [@​bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3488](https://togithub.com/google/cadvisor/pull/3488) **Full Changelog**: google/cadvisor@v0.49.0...v0.49.1 Multi Arch Container Image: gcr.io/cadvisor/cadvisor:v0.49.1 Architecture Specific Container Images: gcr.io/cadvisor/cadvisor-arm:v0.49.1 gcr.io/cadvisor/cadvisor-arm64:v0.49.1 gcr.io/cadvisor/cadvisor-amd64:v0.49.1 Binaries: SHA256 (./cadvisor-v0.49.1-linux-arm) = 5f4128a60c277a5f5182b22ea93c786b1016465934d908c37a4f5ce9d1dfd2b1 SHA256 (./cadvisor-v0.49.1-linux-amd64) = 1d5cc701a3fcdf1e8ed1c86da5304b896a6997d9e6673139e78a6f87812495b0 SHA256 (./cadvisor-v0.49.1-linux-arm64) = c535f46d789599f25c7c680af193d4402da27a98d9828eb2ec916af6256e0c0c ### [`v0.49.0`](https://togithub.com/google/cadvisor/releases/tag/v0.49.0) [Compare Source](https://togithub.com/google/cadvisor/compare/v0.48.1...v0.49.0) #### What's Changed - allow for cadvisor to detect disk stats when the read-only and writeable layers are on separate disks. by [@​kannon92](https://togithub.com/kannon92) in [https://github.com/google/cadvisor/pull/3395](https://togithub.com/google/cadvisor/pull/3395) - build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /cmd by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google/cadvisor/pull/3438](https://togithub.com/google/cadvisor/pull/3438) - upgrade actions version in github workflow by [@​nnnkkk7](https://togithub.com/nnnkkk7) in [https://github.com/google/cadvisor/pull/3443](https://togithub.com/google/cadvisor/pull/3443) - Remove mentions of accelerator from the docs by [@​bobrik](https://togithub.com/bobrik) in [https://github.com/google/cadvisor/pull/3458](https://togithub.com/google/cadvisor/pull/3458) - Reduce kubelet logs 'Failed to create existing container' when kubelet is using crio by [@​dsxing](https://togithub.com/dsxing) in [https://github.com/google/cadvisor/pull/3457](https://togithub.com/google/cadvisor/pull/3457) - Add note about WebUI auth by [@​bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3463](https://togithub.com/google/cadvisor/pull/3463) - Remove section about canary image by [@​discapes](https://togithub.com/discapes) in [https://github.com/google/cadvisor/pull/3472](https://togithub.com/google/cadvisor/pull/3472) - Bump golang to 1.22 by [@​bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3474](https://togithub.com/google/cadvisor/pull/3474) - Bump deps (runc, docker, grpc, golang/x/net) by [@​bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3477](https://togithub.com/google/cadvisor/pull/3477) - Bump to alpine 3.18 and disable libipmctl by [@​bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3483](https://togithub.com/google/cadvisor/pull/3483) #### New Contributors - [@​kannon92](https://togithub.com/kannon92) made their first contribution in [https://github.com/google/cadvisor/pull/3395](https://togithub.com/google/cadvisor/pull/3395) - [@​nnnkkk7](https://togithub.com/nnnkkk7) made their first contribution in [https://github.com/google/cadvisor/pull/3443](https://togithub.com/google/cadvisor/pull/3443) - [@​dsxing](https://togithub.com/dsxing) made their first contribution in [https://github.com/google/cadvisor/pull/3457](https://togithub.com/google/cadvisor/pull/3457) - [@​discapes](https://togithub.com/discapes) made their first contribution in [https://github.com/google/cadvisor/pull/3472](https://togithub.com/google/cadvisor/pull/3472) **Full Changelog**: google/cadvisor@v0.48.1...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
DougManton
referenced
this pull request
in DougManton/opentelemetry-collector-contrib
Mar 13, 2024
…1568) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/google/cadvisor](https://togithub.com/google/cadvisor) | `v0.48.1` -> `v0.49.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/cadvisor (github.com/google/cadvisor)</summary> ### [`v0.49.1`](https://togithub.com/google/cadvisor/releases/tag/v0.49.1) [Compare Source](https://togithub.com/google/cadvisor/compare/v0.49.0...v0.49.1) #### What's Changed - Cherrpick [#&open-telemetry#8203;3485](https://togithub.com/google/cadvisor/issues/3485) to release-v0.49- Remove s390x support by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3486](https://togithub.com/google/cadvisor/pull/3486) - build docker - add --provenance=false flag by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3488](https://togithub.com/google/cadvisor/pull/3488) **Full Changelog**: google/cadvisor@v0.49.0...v0.49.1 Multi Arch Container Image: gcr.io/cadvisor/cadvisor:v0.49.1 Architecture Specific Container Images: gcr.io/cadvisor/cadvisor-arm:v0.49.1 gcr.io/cadvisor/cadvisor-arm64:v0.49.1 gcr.io/cadvisor/cadvisor-amd64:v0.49.1 Binaries: SHA256 (./cadvisor-v0.49.1-linux-arm) = 5f4128a60c277a5f5182b22ea93c786b1016465934d908c37a4f5ce9d1dfd2b1 SHA256 (./cadvisor-v0.49.1-linux-amd64) = 1d5cc701a3fcdf1e8ed1c86da5304b896a6997d9e6673139e78a6f87812495b0 SHA256 (./cadvisor-v0.49.1-linux-arm64) = c535f46d789599f25c7c680af193d4402da27a98d9828eb2ec916af6256e0c0c ### [`v0.49.0`](https://togithub.com/google/cadvisor/releases/tag/v0.49.0) [Compare Source](https://togithub.com/google/cadvisor/compare/v0.48.1...v0.49.0) #### What's Changed - allow for cadvisor to detect disk stats when the read-only and writeable layers are on separate disks. by [@&open-telemetry#8203;kannon92](https://togithub.com/kannon92) in [https://github.com/google/cadvisor/pull/3395](https://togithub.com/google/cadvisor/pull/3395) - build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /cmd by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/google/cadvisor/pull/3438](https://togithub.com/google/cadvisor/pull/3438) - upgrade actions version in github workflow by [@&open-telemetry#8203;nnnkkk7](https://togithub.com/nnnkkk7) in [https://github.com/google/cadvisor/pull/3443](https://togithub.com/google/cadvisor/pull/3443) - Remove mentions of accelerator from the docs by [@&open-telemetry#8203;bobrik](https://togithub.com/bobrik) in [https://github.com/google/cadvisor/pull/3458](https://togithub.com/google/cadvisor/pull/3458) - Reduce kubelet logs 'Failed to create existing container' when kubelet is using crio by [@&open-telemetry#8203;dsxing](https://togithub.com/dsxing) in [https://github.com/google/cadvisor/pull/3457](https://togithub.com/google/cadvisor/pull/3457) - Add note about WebUI auth by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3463](https://togithub.com/google/cadvisor/pull/3463) - Remove section about canary image by [@&open-telemetry#8203;discapes](https://togithub.com/discapes) in [https://github.com/google/cadvisor/pull/3472](https://togithub.com/google/cadvisor/pull/3472) - Bump golang to 1.22 by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3474](https://togithub.com/google/cadvisor/pull/3474) - Bump deps (runc, docker, grpc, golang/x/net) by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3477](https://togithub.com/google/cadvisor/pull/3477) - Bump to alpine 3.18 and disable libipmctl by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3483](https://togithub.com/google/cadvisor/pull/3483) #### New Contributors - [@&open-telemetry#8203;kannon92](https://togithub.com/kannon92) made their first contribution in [https://github.com/google/cadvisor/pull/3395](https://togithub.com/google/cadvisor/pull/3395) - [@&open-telemetry#8203;nnnkkk7](https://togithub.com/nnnkkk7) made their first contribution in [https://github.com/google/cadvisor/pull/3443](https://togithub.com/google/cadvisor/pull/3443) - [@&open-telemetry#8203;dsxing](https://togithub.com/dsxing) made their first contribution in [https://github.com/google/cadvisor/pull/3457](https://togithub.com/google/cadvisor/pull/3457) - [@&open-telemetry#8203;discapes](https://togithub.com/discapes) made their first contribution in [https://github.com/google/cadvisor/pull/3472](https://togithub.com/google/cadvisor/pull/3472) **Full Changelog**: google/cadvisor@v0.48.1...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
XinRanZhAWS
referenced
this pull request
in XinRanZhAWS/opentelemetry-collector-contrib
Mar 13, 2024
…1568) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/google/cadvisor](https://togithub.com/google/cadvisor) | `v0.48.1` -> `v0.49.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/cadvisor (github.com/google/cadvisor)</summary> ### [`v0.49.1`](https://togithub.com/google/cadvisor/releases/tag/v0.49.1) [Compare Source](https://togithub.com/google/cadvisor/compare/v0.49.0...v0.49.1) #### What's Changed - Cherrpick [#&open-telemetry#8203;3485](https://togithub.com/google/cadvisor/issues/3485) to release-v0.49- Remove s390x support by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3486](https://togithub.com/google/cadvisor/pull/3486) - build docker - add --provenance=false flag by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3488](https://togithub.com/google/cadvisor/pull/3488) **Full Changelog**: google/cadvisor@v0.49.0...v0.49.1 Multi Arch Container Image: gcr.io/cadvisor/cadvisor:v0.49.1 Architecture Specific Container Images: gcr.io/cadvisor/cadvisor-arm:v0.49.1 gcr.io/cadvisor/cadvisor-arm64:v0.49.1 gcr.io/cadvisor/cadvisor-amd64:v0.49.1 Binaries: SHA256 (./cadvisor-v0.49.1-linux-arm) = 5f4128a60c277a5f5182b22ea93c786b1016465934d908c37a4f5ce9d1dfd2b1 SHA256 (./cadvisor-v0.49.1-linux-amd64) = 1d5cc701a3fcdf1e8ed1c86da5304b896a6997d9e6673139e78a6f87812495b0 SHA256 (./cadvisor-v0.49.1-linux-arm64) = c535f46d789599f25c7c680af193d4402da27a98d9828eb2ec916af6256e0c0c ### [`v0.49.0`](https://togithub.com/google/cadvisor/releases/tag/v0.49.0) [Compare Source](https://togithub.com/google/cadvisor/compare/v0.48.1...v0.49.0) #### What's Changed - allow for cadvisor to detect disk stats when the read-only and writeable layers are on separate disks. by [@&open-telemetry#8203;kannon92](https://togithub.com/kannon92) in [https://github.com/google/cadvisor/pull/3395](https://togithub.com/google/cadvisor/pull/3395) - build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /cmd by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/google/cadvisor/pull/3438](https://togithub.com/google/cadvisor/pull/3438) - upgrade actions version in github workflow by [@&open-telemetry#8203;nnnkkk7](https://togithub.com/nnnkkk7) in [https://github.com/google/cadvisor/pull/3443](https://togithub.com/google/cadvisor/pull/3443) - Remove mentions of accelerator from the docs by [@&open-telemetry#8203;bobrik](https://togithub.com/bobrik) in [https://github.com/google/cadvisor/pull/3458](https://togithub.com/google/cadvisor/pull/3458) - Reduce kubelet logs 'Failed to create existing container' when kubelet is using crio by [@&open-telemetry#8203;dsxing](https://togithub.com/dsxing) in [https://github.com/google/cadvisor/pull/3457](https://togithub.com/google/cadvisor/pull/3457) - Add note about WebUI auth by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3463](https://togithub.com/google/cadvisor/pull/3463) - Remove section about canary image by [@&open-telemetry#8203;discapes](https://togithub.com/discapes) in [https://github.com/google/cadvisor/pull/3472](https://togithub.com/google/cadvisor/pull/3472) - Bump golang to 1.22 by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3474](https://togithub.com/google/cadvisor/pull/3474) - Bump deps (runc, docker, grpc, golang/x/net) by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3477](https://togithub.com/google/cadvisor/pull/3477) - Bump to alpine 3.18 and disable libipmctl by [@&open-telemetry#8203;bobbypage](https://togithub.com/bobbypage) in [https://github.com/google/cadvisor/pull/3483](https://togithub.com/google/cadvisor/pull/3483) #### New Contributors - [@&open-telemetry#8203;kannon92](https://togithub.com/kannon92) made their first contribution in [https://github.com/google/cadvisor/pull/3395](https://togithub.com/google/cadvisor/pull/3395) - [@&open-telemetry#8203;nnnkkk7](https://togithub.com/nnnkkk7) made their first contribution in [https://github.com/google/cadvisor/pull/3443](https://togithub.com/google/cadvisor/pull/3443) - [@&open-telemetry#8203;dsxing](https://togithub.com/dsxing) made their first contribution in [https://github.com/google/cadvisor/pull/3457](https://togithub.com/google/cadvisor/pull/3457) - [@&open-telemetry#8203;discapes](https://togithub.com/discapes) made their first contribution in [https://github.com/google/cadvisor/pull/3472](https://togithub.com/google/cadvisor/pull/3472) **Full Changelog**: google/cadvisor@v0.48.1...v0.49.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was removed in #3206. cc @liggitt @bobbypage