Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manager: require higher verbosity level for container info misses #3412

Merged
merged 1 commit into from
Oct 16, 2023
Merged

manager: require higher verbosity level for container info misses #3412

merged 1 commit into from
Oct 16, 2023

Conversation

hhromic
Copy link
Contributor

@hhromic hhromic commented Oct 10, 2023

This PR increases the required verbosity level for logging container stats info misses such as:

manager.go:694] Error getting data for container / because of race condition

When not scrapping root container metrics (using -disable_root_cgroup_stats), the above log message is repeated for every metrics scrape request. The error in this case is expected due to to the container stats info not having stats for /.

Fixes #3407
Similar to #3341

@google-cla
Copy link

google-cla bot commented Oct 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @hhromic. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* avoids repeated message when not scrapping root container metrics
@hhromic hhromic changed the title manager: require higher verbosity level for stats cache misses require higher verbosity level for container info misses Oct 11, 2023
@hhromic hhromic changed the title require higher verbosity level for container info misses manager: require higher verbosity level for container info misses Oct 11, 2023
@dims
Copy link
Collaborator

dims commented Oct 16, 2023

/ok-to-test

Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims dims merged commit 2f9ab2e into google:master Oct 16, 2023
14 checks passed
@hhromic hhromic deleted the containers-info-verbosity-level branch October 16, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manager.go:694] Error getting data for container / because of race condition
3 participants