Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce useless check in resctrl file system #3264

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

Rouzip
Copy link
Contributor

@Rouzip Rouzip commented Mar 4, 2023

Fix #3263

In the resctrl file system, there will be automatically created mode and size files, so we can remove the useless check for them in the findGroup function.

@k8s-ci-robot
Copy link
Collaborator

Hi @Rouzip. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rouzip Rouzip changed the title add two more file reduce useless check in resctrl file system Mar 4, 2023
@Creatone Creatone self-assigned this Mar 4, 2023
@Rouzip
Copy link
Contributor Author

Rouzip commented Mar 8, 2023

Hello, can you help review my pr? @Creatone

@Creatone
Copy link
Collaborator

/ok-to-test

Copy link
Collaborator

@Creatone Creatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Creatone Creatone merged commit 487e64a into google:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resctrl system remove mode&size check
3 participants