Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Distances field to machine.Node #3179

Merged
merged 3 commits into from
Oct 3, 2022

Conversation

PiotrProkop
Copy link
Contributor

Add information about NUMA distances to Node struct.

Signed-off-by: PiotrProkop <pprokop@nvidia.com>
@k8s-ci-robot
Copy link
Collaborator

Hi @PiotrProkop. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Creatone
Copy link
Collaborator

Creatone commented Oct 3, 2022

/ok-to-test

Copy link
Collaborator

@Creatone Creatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils/sysinfo/sysinfo_test.go Outdated Show resolved Hide resolved
Signed-off-by: PiotrProkop <pprokop@nvidia.com>
@PiotrProkop
Copy link
Contributor Author

@Creatone thanks for review, metrics updated

Copy link
Collaborator

@Creatone Creatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit and it can be merged 👍

docs/storage/prometheus.md Outdated Show resolved Hide resolved
Signed-off-by: PiotrProkop <pprokop@nvidia.com>
Copy link
Collaborator

@Creatone Creatone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Creatone Creatone merged commit 24dd1de into google:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants