Retry containerd task api request when task is in unknown state #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbypage
force-pushed
the
retry-containerd-pid
branch
from
cd1e319
to
7462512
Compare
bobbypage
changed the title
|
/approve |
bobbypage
force-pushed
the
retry-containerd-pid
branch
from
7462512
to
6e73251
Compare
In some cases, it appears that containerd task api can return a zero pid when the task is not ready yet. In these cases, the process task state is reported to be in unknown state. In this case, we should retry the containerd task api request as the task can take some time to move away from unknown state and be initialized. Signed-off-by: David Porter <porterdavid@google.com>
bobbypage
force-pushed
the
retry-containerd-pid
branch
from
6e73251
to
798c75f
Compare
|
LGTM |
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it appears that containerd task api can return a zero pid
when the task is not ready yet. In these cases, the process task state
is reported to be in unknown state. In this case, we should retry the
containerd task api request as the task can take some time to move away
from unknown state and be initialized.
Signed-off-by: David Porter porterdavid@google.com