-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if docker can't connect during InitializeFSContext , do not add image dev info to real fs info label cache #2934
Conversation
Hi @Dingshujie. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bobbypage can you review this PR? |
/ok-to-test |
Looks like tests are failing?
|
20e2e72
to
020ac31
Compare
/retest |
020ac31
to
24ae795
Compare
test case not set driver name, so lead test failed. |
thanks, LGTM. |
when cadvisor Initialize FS Context, docker restart or something wrong happen, context.Dokcer.Driver set to "", now default use /var/lib/docker device usage as image fs usage. if we use device mapper as storage driver, we may get wrong image fs usage inforamation, so may be lead kubelet image gc manager to get a wrong information。