Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing items to Prometheus container metrics table #2927

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

eero-t
Copy link
Contributor

@eero-t eero-t commented Aug 20, 2021

Fix following in the Prometheus container metrics table in the documentation:

  • Sort table by container metrics names
  • Add items for missing container metrics
  • Add missing option names for all metrics

Best reviewed from: https://github.com/eero-t/cadvisor/blob/prometheus-metrics-doc/docs/storage/prometheus.md

Fixes: #2926

@k8s-ci-robot
Copy link
Collaborator

Hi @eero-t. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobbypage
Copy link
Collaborator

/ok-to-test

@bobbypage
Copy link
Collaborator

LGTM, thank you for the doc updates!!

@bobbypage bobbypage merged commit 85796f1 into google:master Aug 25, 2021
@eero-t eero-t deleted the prometheus-metrics-doc branch August 26, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage/prometheus.md misses many of the metrics provided by cAdvisor
3 participants