Upgrade cAdvisor version in k8s deployment. #2853
Conversation
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
|
/ok-to-test |
| resources: | ||
| requests: | ||
| memory: 200Mi | ||
| cpu: 150m | ||
| memory: 1000Mi |
There was a problem hiding this comment.
just curious, why is the bump in cpu and memory needed?
There was a problem hiding this comment.
Got this one:
[pszulik@node200 ~]$ curl 10.233.79.136:8080/metrics > out
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (7) Failed connect to 10.233.79.136:8080; Connection refused
Lack of resources...
There was a problem hiding this comment.
I see, sounds good to bump then. However, it seems like a large bump (requests 200Mi -> 1000Mi ; cpu 100m -> 500m). I don't have any objections but just curious how you picked those... or if it's just a rough guess :)
There was a problem hiding this comment.
It has not been changed for a while but such a huge increase is a bit worrying to me too. @Creatone have you tried to set any lower value?
There was a problem hiding this comment.
Resources are going to vary based on the number of containers on the node.
You should also check to see if there were any additional --disable_metrics added during that time period that we need to ignore (if we are ignoring any).
There was a problem hiding this comment.
Can you now check out the values?
|
@bobbypage there are few recently reported issues about performance. I think we can merge this PR and investigate reported issues. |
|
Sounds good, LGTM. |
Signed-off-by: Paweł Szulik pawel.szulik@intel.com