Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting fixes to #2743 and #2783 to 0.38 #2820

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

iwankgb
Copy link
Collaborator

@iwankgb iwankgb commented Mar 4, 2021

Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@critical.today>
Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@critical.today>
…ing count of unique properties

Signed-off-by: Maciej "Iwan" Iwanowski <maciej.iwanowski@critical.today>
@google-cla google-cla bot added the cla: yes label Mar 4, 2021
@iwankgb iwankgb requested a review from bobbypage March 4, 2021 15:23
@iwankgb iwankgb changed the title Porting fixes to #2743 and #2783 Porting fixes to #2743 and #2783 to 0.38 Mar 4, 2021
…ntroduced in google#2418

Signed-off-by: Kris Gambirazzi <kris.gambirazzi@transferwise.com>
@google-cla
Copy link

google-cla bot commented Mar 10, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 10, 2021
@iwankgb
Copy link
Collaborator Author

iwankgb commented Mar 10, 2021

@kgtw we need your consent to merge this PR.

@kgtw
Copy link
Contributor

kgtw commented Mar 10, 2021

approved

@iwankgb
Copy link
Collaborator Author

iwankgb commented Mar 10, 2021

@kgtw it needs to be very special comment: #2820 (comment)

@kgtw
Copy link
Contributor

kgtw commented Mar 10, 2021

@googlebot I consent

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 10, 2021
@bobbypage
Copy link
Collaborator

Thanks for putting together cherrypick, LGTM.

@bobbypage bobbypage merged commit 8c644f2 into google:release-v0.38 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants