Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump runc to v1.0.0-rc93 #2809

Merged
merged 1 commit into from
Feb 20, 2021
Merged

bump runc to v1.0.0-rc93 #2809

merged 1 commit into from
Feb 20, 2021

Conversation

harche
Copy link
Contributor

@harche harche commented Feb 19, 2021

bump runc to v1.0.0-rc93.

This version of runc brings in really needed fixes for some of the metrics.

Signed-off-by: Harshal Patil harpatil@redhat.com

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@google-cla google-cla bot added the cla: yes label Feb 19, 2021
@k8s-ci-robot
Copy link
Collaborator

Hi @harche. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche
Copy link
Contributor Author

harche commented Feb 19, 2021

/cc @ehashman @bobbypage

Copy link
Collaborator

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobbypage
Copy link
Collaborator

LGTM, we definitely want to update to runc rc93. Only question, in past @dims updated runc in sync with containerd. And containerd only updated to runc rc93 in containerd 1.5, but that's still in beta and not released yet.

@dims do you have thoughts, do we need to wait and update containerd and runc together or is it ok to just update runc for now?

@dims
Copy link
Collaborator

dims commented Feb 20, 2021

@bobbypage updating containerd to rc93 has started ... containerd/containerd#5036

So we can go ahead here in cadvisor. +1 from me!

@bobbypage
Copy link
Collaborator

got it, thanks @dims and @harche!

@bobbypage bobbypage merged commit 88892b0 into google:master Feb 20, 2021
@harche harche deleted the update_runc branch February 22, 2021 06:22
@harche
Copy link
Contributor Author

harche commented Feb 22, 2021

Thanks @bobbypage. I was wondering when are we planning to cut the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants