Update to some newer dependencies including docker #2790
Conversation
dims
changed the title
dims
force-pushed
the
update-to-latest-sha/tag
branch
3 times, most recently
from
8743839
to
c0e6c94
Compare
dims
changed the title
dims
changed the title
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
update-to-latest-sha/tag
branch
from
c0e6c94
to
b013405
Compare
dims
changed the title
| github.com/morikuni/aec v1.0.0 // indirect | ||
| github.com/opencontainers/go-digest v1.0.0 // indirect | ||
| github.com/opencontainers/image-spec v1.0.1 // indirect | ||
| github.com/opencontainers/runc v1.0.0-rc92 | ||
| github.com/opencontainers/runtime-spec v1.0.3-0.20200728170252-4d89ac9fbff6 | ||
| github.com/opencontainers/runc v1.0.0-rc92.0.20210122051217-c69ae759fbf5 |
There was a problem hiding this comment.
a little curious why this changed, shouldn't this stay on rc-92 instead of opencontainers/runc@c69ae75 ?
There was a problem hiding this comment.
we need to move to newer runc as there's a older runc uses the older sys/mountinfo (and moving to newer docker we need to move to newer sys/mountinfo). there's a type mismatch (FSType vs FsType i mountinfo).
there's a lot of weird dance we have to do to get runc, containerd, cadvisor, k8s all in line. this is one of those.
we are also trying to get runc rc-93 out the door, so going to a SHA now will help make sure nothing is broken as well.
There was a problem hiding this comment.
got it, so we'll need to ensure to update to rc-93 (when it will be released) before cutting next cAdvisor release and vendoring in k/k right?
also thinking i hope it will mean rc-93 will be released in time for next k/k 1.21 release :)
| github.com/opencontainers/runc v1.0.0-rc92 | ||
| github.com/opencontainers/runtime-spec v1.0.3-0.20200728170252-4d89ac9fbff6 | ||
| github.com/opencontainers/runc v1.0.0-rc92.0.20210122051217-c69ae759fbf5 | ||
| github.com/opencontainers/runtime-spec v1.0.3-0.20200929063507-e6143ca7d51d |
There was a problem hiding this comment.
curious why runtime-spec needed to change? e.g. in containerd pr it's still on 4d89ac9fbff6 after your PR containerd/containerd#4926
There was a problem hiding this comment.
docker switched ahead of containerd ... don't ask :)
There was a problem hiding this comment.
ack :) just want to ensure it won't cause issues when vendoring back into k/k due to containerd and cadvisor pointing to different sha's for runtime-spec...
|
Resctrl part LGTM |
|
Chatted with @dims offline as well. Note: This PR is updating runc from We'll need to ensure we update to tagged runc rc93 when it will be cut: xref: opencontainers/runc#2659 prior to cutting cAdvisor release |
|
LGTM, thanks @dims! |
Essentially updated docker and the rest of the changes just flowed from that ...
Signed-off-by: Davanum Srinivas davanum@gmail.com