Support nfs in processMounts #2787
Conversation
|
Hi @gjkim42. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @bobbypage |
gjkim42
force-pushed
the
support-nfs-in-processmounts
branch
from
787e08d
to
63d2c10
Compare
gjkim42
force-pushed
the
support-nfs-in-processmounts
branch
from
63d2c10
to
adaddcc
Compare
gjkim42
changed the title
|
/ok-to-test |
fs/fs.go
Outdated
| @@ -170,7 +170,7 @@ func processMounts(mounts []*mount.Info, excludedMountpointPrefixes []string) ma | |||
| partitions := make(map[string]partition) | |||
|
|
|||
| supportedFsType := map[string]bool{ | |||
| // all ext systems are checked through prefix. | |||
| // all ext and nfs systems are checked through prefix. | |||
There was a problem hiding this comment.
is there any reason we can't just add "nfs" : true to supportedFsType as opposed to special casing it below?
I'm not clear why "ext" is special cased unlike all the other file system types here.
There was a problem hiding this comment.
I think "ext" was special cased because there are a number of ext filesystems. (ext3, ext4...)
And there are a number of NFS too. (nfs3, nfs4...)
Do you prefer to add "nfs3": true, "nfs4": true?
There was a problem hiding this comment.
I see, that makes sense.
I'm fine with either, but if you think the prefix check is easier, let's update the comment to make it clear why some fs type check via prefix vs some in supportedFsType (i.e. your explanation regarding "version number" of filesystem).
- Fix kubenetes issue kubernetes/kubernetes#98009
gjkim42
force-pushed
the
support-nfs-in-processmounts
branch
from
adaddcc
to
a228e69
Compare
Fix kubenetes issue kubernetes/kubernetes#98009
Helps with the situation when the kubelet starts with --root-dir=$NFS_DIR.