Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: run go mod tidy #2731

Merged
merged 1 commit into from
Nov 13, 2020
Merged

vendor: run go mod tidy #2731

merged 1 commit into from
Nov 13, 2020

Conversation

bobbypage
Copy link
Collaborator

@bobbypage bobbypage commented Nov 13, 2020

#2716 updated many dependencies some of which we reverted in #2726 and #2728

In the process, looks like go mod tidy was not run, so the go.mod wasn't up to date.

Before this change:

$ go list -m all | wc -l
271

After go mod tidy:

$ go list -m all | wc -l
140

We need to also followup and add go mod tidy check to CI, created #2730 to track that

@google-cla google-cla bot added the cla: yes label Nov 13, 2020
@bobbypage bobbypage merged commit 10d7b8f into google:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant