Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not initialize libipmctl package when getting an error from nvm_init() #2723

Merged
merged 1 commit into from
Nov 10, 2020
Merged

do not initialize libipmctl package when getting an error from nvm_init() #2723

merged 1 commit into from
Nov 10, 2020

Conversation

Creatone
Copy link
Collaborator

Fixes #2721

@iwankgb

Signed-off-by: Paweł Szulik pawel.szulik@intel.com

do not initialize libipmctl package when getting an error from nvm_in…
7555684 
…it()

Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@k8s-ci-robot
Copy link
Collaborator

Hi @Creatone. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Nov 10, 2020

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Nov 10, 2020

Looks more then reasonable to me.

@bobbypage bobbypage merged commit 6819838 into google:master Nov 10, 2020
@bobbypage bobbypage mentioned this pull request Nov 10, 2020
Merged
@Creatone Creatone mentioned this pull request Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage bobbypage approved these changes

Assignees
No one assigned
Labels
cla: yes ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Libipmctl package initializes even if there is an error.
4 participants
@Creatone @k8s-ci-robot @iwankgb @bobbypage