Add stats to stdout storage #2612
Conversation
|
Hi @piowag. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| @@ -32,27 +33,62 @@ type stdoutStorage struct { | |||
| } | |||
|
|
|||
| const ( | |||
| colTimestamp = "timestamp" | |||
| // CPU Uasge | |||
| colCpuCumulativeUsage = "cpu_cumulative_usage" | |||
There was a problem hiding this comment.
I'm fine with the rename, but just in-case someone is using these metrics, lets keep the old name around as well, with a link to an issue to remove it in a few releases (v0.39.0)
|
cc: @Creatone |
Signed-off-by: Piotr Wagner <piotr.wagner@intel.com>
|
This looks good. Do you think we have enough metrics here where we need to start respecting --ignore-metrics? I believe the current PR will just have zero values for disabled metrics, which is acceptable, but adds to the load for any backends that process the data. |
Add stats to stdout storage: memory, hugetlb, perf, resctrl, referenced memory