Stop using the global prometheus registry

[grobie]

Replace usage of the global Prometheus registry with a private registry
object which will be exported under the given prometheus path.

Fixes #1459.

[k8s-bot]

Jenkins GCE e2e

Build/test passed for commit d30400f.

• Build Log

[grobie]

This removes the http_* metrics. The instrument handler is deprecated as it needs to be rewritten. Not sure you would like to keep them?

[grobie]

Depending on the outcome of the discussion in kubernetes/kubernetes#32638 we'll need to change the integration of cAdvsior in the kubelet once this PR is merged. We probably could also just stop using RegisterPrometheusHandler in the kubernetes code base to avoid the usage of the global registry.

[jimmidyson]

👍

I don't mind the loss of http_* metrics.

[jimmidyson]

@grobie Needs a rebase please.

[grobie]

@jimmidyson done

[k8s-bot]

Jenkins GCE e2e

Build/test passed for commit 2720a41.

• Build Log

[cmluciano]

Is this awaiting a maintainer review?

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[googlebot]

CLAs look good, thanks!

[grobie]

Anything left for me to do here? If you're not going to accept this, I can also just close it. @jimmidyson @dashpole

[dashpole]

W0416 16:16:43.668] vendor/github.com/prometheus/client_golang/prometheus/promhttp/http.go:75: undefined: prometheus.DefaultGatherer
W0416 16:16:43.668] vendor/github.com/prometheus/client_golang/prometheus/promhttp/http.go:80: undefined: prometheus.Gatherer
Looks like it doesnt compile?

[cmluciano]

Might be related prometheus/client_golang@f0c45ac ?

[grobie]

I'm sorry for the noise @dashpole. I updated the dependencies (which will bring several improvements to the metrics exported by Prometheus) and that fixed the build.

[dashpole]

sorry, this fell off of my radar.
please rebase and squash

[grobie]

@dashpole you sure you want me to squash these two commits together? I'm not sure I see the point, they are independent changes which can be applied in isolation. Given the massive diff caused by vendor updates, I understood it to be best practice to separate them from actual code changes.

[dashpole]

usually, we just squash to make the git tree more readable, but I see your point. We can merge this as is once tests pass.

[grobie]

@dashpole another week of ping pong ;-)

[dashpole]

Ill see if I can get the test infra stuff fixed today. Then we can merge this.

[Random-Liu]

Verified that this PR causes #1671 and kubernetes/kubernetes#47744.

It seems that Prometheus v0.8.0 added some consistency check prometheus/client_golang#214, which breaks the metrics.

Filed #1679 to work around this for now. We should figure out and fix the inconsistent metrics in the future.