Skip to content

Commit

Permalink
Define a NID for P-384 + Kyber768.
Browse files Browse the repository at this point in the history
We do not expect to support this combination, but other consumers of
BoringSSL may choose to.

Change-Id: Ifdafa6a0032af078343bb9ecd80eea89eee582be
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/57705
Auto-Submit: Adam Langley <agl@google.com>
Reviewed-by: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
  • Loading branch information
agl authored and Boringssl LUCI CQ committed Feb 28, 2023
1 parent f88b7c8 commit 028bae7
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
5 changes: 4 additions & 1 deletion crypto/obj/obj_dat.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
/* This file is generated by crypto/obj/objects.go. */


#define NUM_NID 966
#define NUM_NID 967

static const uint8_t kObjectData[] = {
/* NID_rsadsi */
Expand Down Expand Up @@ -8784,6 +8784,7 @@ static const ASN1_OBJECT kObjects[NUM_NID] = {
{"HKDF", "hkdf", NID_hkdf, 0, NULL, 0},
{"X25519Kyber768", "X25519Kyber768", NID_X25519Kyber768, 0, NULL, 0},
{"P256Kyber768", "P256Kyber768", NID_P256Kyber768, 0, NULL, 0},
{"P384Kyber768", "P384Kyber768", NID_P384Kyber768, 0, NULL, 0},
};

static const uint16_t kNIDsInShortNameOrder[] = {
Expand Down Expand Up @@ -8918,6 +8919,7 @@ static const uint16_t kNIDsInShortNameOrder[] = {
749 /* Oakley-EC2N-3 */,
750 /* Oakley-EC2N-4 */,
965 /* P256Kyber768 */,
966 /* P384Kyber768 */,
9 /* PBE-MD2-DES */,
168 /* PBE-MD2-RC2-64 */,
10 /* PBE-MD5-DES */,
Expand Down Expand Up @@ -9833,6 +9835,7 @@ static const uint16_t kNIDsInLongNameOrder[] = {
371 /* OCSP Service Locator */,
180 /* OCSP Signing */,
965 /* P256Kyber768 */,
966 /* P384Kyber768 */,
161 /* PBES2 */,
69 /* PBKDF2 */,
162 /* PBMAC1 */,
Expand Down
1 change: 1 addition & 0 deletions crypto/obj/obj_mac.num
Original file line number Diff line number Diff line change
Expand Up @@ -954,3 +954,4 @@ sha512_256 962
hkdf 963
X25519Kyber768 964
P256Kyber768 965
P384Kyber768 966
1 change: 1 addition & 0 deletions crypto/obj/objects.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,7 @@ secg-scheme 14 3 : dhSinglePass-cofactorDH-sha512kdf-scheme
: CECPQ2
: X25519Kyber768
: P256Kyber768
: P384Kyber768

# See RFC 8410.
1 3 101 110 : X25519
Expand Down
3 changes: 3 additions & 0 deletions include/openssl/nid.h
Original file line number Diff line number Diff line change
Expand Up @@ -4261,6 +4261,9 @@ extern "C" {
#define SN_P256Kyber768 "P256Kyber768"
#define NID_P256Kyber768 965

#define SN_P384Kyber768 "P384Kyber768"
#define NID_P384Kyber768 966


#if defined(__cplusplus)
} /* extern C */
Expand Down

0 comments on commit 028bae7

Please sign in to comment.