Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create CSS vars for SVG patterns. #8671

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

johnnesky
Copy link
Member

The basics

The details

Resolves

Fixes #8272

We'll need a related PR in blockly-samples that adapts the screenshot plugin to be aware of CSS vars.

Proposed Changes

Adds CSS variables scoped to the injection div referencing the SVG pattern ids so that CSS can use these consistent variable names instead of the random ids that were previously assigned to SVG attributes.

Reason for Changes

So that renderer CSS can customize and override how SVG patterns are used.

Test Coverage

I did not create any new tests, but all existing tests pass and I manually tested that the filters appear to be rendering correctly.

Documentation

N/A

Additional Information

N/A

@johnnesky johnnesky requested a review from a team as a code owner November 23, 2024 01:28
@johnnesky johnnesky requested a review from gonfunko November 23, 2024 01:28
@github-actions github-actions bot added the PR: fix Fixes a bug label Nov 23, 2024
@gonfunko
Copy link
Contributor

gonfunko commented Dec 2, 2024

I think this also fixes #1403?

@johnnesky
Copy link
Member Author

I think this also fixes #1403?

Depends on what they wanted to do to the disabled pattern. I wouldn't close that yet without putting some thought into it.

@johnnesky johnnesky merged commit 4230956 into google:rc/v12.0.0 Dec 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants