refactor!: Use IVariableMap instead of VariableMap #8401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
changed the title
github-actions
bot
added
breaking change
rachel-fenichel
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
-[x] I validated my changes
The details
Resolves
Fixes #8371, #8079, #8075
Proposed Changes
This PR uses IVariableMap in place of hardcoding VariableMap. It also refactors variable deletion handling; the VariableMap methods
getVariableUsesByIdanddeleteVariableByIdare deprecated and moved to theVariablesnamespace.Breaking Change
The
VariableMap.deleteVariablemethod now unconditionally deletes uses of the variable in question as well.