Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: use :focus pseudo class instead of blocklyFocused #8360

Merged
merged 6 commits into from
Jul 27, 2024

Conversation

Skye967
Copy link

@Skye967 Skye967 commented Jul 14, 2024

… style to :focus

The basics

The details

Resolves

Fixes #8326

Proposed Changes

Remove the blocklyFocused class from being assigned in menu.ts and dropdowndiv.ts
Change the styles in css.ts to use the :focus css pseudo class

Removed the blocklyFocused class from being assigned in menu.ts and dropdowndiv.ts
Changed the styles in css.ts to use the :focus css pseudo class

Reason for Changes

Test Coverage

Not necessary

Documentation

No it won't affect anything. just some minor css changes

Additional Information

@Skye967 Skye967 requested a review from a team as a code owner July 14, 2024 22:13
@Skye967 Skye967 requested a review from BeksOmega July 14, 2024 22:13
Copy link

google-cla bot commented Jul 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@Skye967
Copy link
Author

Skye967 commented Jul 14, 2024

Sorry about that, getting used to the naming conventions and I submitted the CLA. Other than that, do the changes look good?

@BeksOmega
Copy link
Collaborator

Hello! Thanks for the fix and for signing the CLA :D

It looks like your branch has a few extra commits. To remove the commits that aren't yours, you can rebase your branch on top of the latest rc/v12.0.0 branch. This will remove any commits that were added to rc/v12.0.0 since you created your branch.

Here are the steps to do that:

  1. Fetch the latest changes from rc/v12.0.0:

    git fetch upstream rc/v12.0.0
  2. Checkout your branch:

    git checkout [your-branch-name]
  3. Start an interactive rebase:

    git rebase -i upstream/rc/v12.0.0
  4. In the editor that opens, identify the commits that aren't yours. These are likely the ones at the top of the list.

  5. Change the word pick to drop for each commit you want to remove.

  6. Save and close the editor.

  7. Force push your changes to your branch: Note that force pushing is a dangerous operation because it overwrites commit history, so if you dropped the wrong commits you could lose work.

    git push -f origin [your-branch-name]

Once you've done this, the PR should only contain your commits.

Let me know if you have any questions or run into any issues!

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as changes requested.

@Skye967
Copy link
Author

Skye967 commented Jul 18, 2024

Thank you, I cleared out those other commits. Is everything good now?

@BeksOmega BeksOmega changed the title Skye dev fix: use :focus pseudo class instead of blocklyFocused Jul 22, 2024
@github-actions github-actions bot added the PR: fix Fixes a bug label Jul 22, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but changes to the dropdown div look good!

@@ -119,7 +118,7 @@ let content = `
box-shadow: 0 0 3px 1px rgba(0,0,0,.3);
}

.blocklyDropDownDiv.blocklyFocused {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another reference to .blocklyFocused in this file, could you remove it as well?

@Skye967
Copy link
Author

Skye967 commented Jul 24, 2024

Went of core css and made some changes.

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet LGTM =) I'll get this merged once CI passes

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the lint errors?

@Skye967
Copy link
Author

Skye967 commented Jul 26, 2024

I believe everything is good now.

@BeksOmega
Copy link
Collaborator

Thanks for your hard work on this!

@BeksOmega BeksOmega merged commit af0a724 into google:rc/v12.0.0 Jul 27, 2024
7 checks passed
@BeksOmega BeksOmega changed the title fix: use :focus pseudo class instead of blocklyFocused fix!: use :focus pseudo class instead of blocklyFocused Jul 27, 2024
@BeksOmega BeksOmega added the breaking change Used to mark a PR or issue that changes our public APIs. label Jul 27, 2024
@github-actions github-actions bot removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Jul 27, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants