-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: use :focus
pseudo class instead of blocklyFocused
#8360
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
Sorry about that, getting used to the naming conventions and I submitted the CLA. Other than that, do the changes look good? |
Hello! Thanks for the fix and for signing the CLA :D It looks like your branch has a few extra commits. To remove the commits that aren't yours, you can rebase your branch on top of the latest Here are the steps to do that:
Once you've done this, the PR should only contain your commits. Let me know if you have any questions or run into any issues! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this as changes requested.
Thank you, I cleared out those other commits. Is everything good now? |
:focus
pseudo class instead of blocklyFocused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but changes to the dropdown div look good!
@@ -119,7 +118,7 @@ let content = ` | |||
box-shadow: 0 0 3px 1px rgba(0,0,0,.3); | |||
} | |||
|
|||
.blocklyDropDownDiv.blocklyFocused { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another reference to .blocklyFocused
in this file, could you remove it as well?
Went of core css and made some changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet LGTM =) I'll get this merged once CI passes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the lint errors?
I believe everything is good now. |
Thanks for your hard work on this! |
:focus
pseudo class instead of blocklyFocused
:focus
pseudo class instead of blocklyFocused
… style to :focus
The basics
The details
Resolves
Fixes #8326
Proposed Changes
Remove the blocklyFocused class from being assigned in menu.ts and dropdowndiv.ts
Change the styles in css.ts to use the :focus css pseudo class
Removed the blocklyFocused class from being assigned in menu.ts and dropdowndiv.ts
Changed the styles in css.ts to use the :focus css pseudo class
Reason for Changes
Test Coverage
Not necessary
Documentation
No it won't affect anything. just some minor css changes
Additional Information