Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add addClass and removeClass methods to blockSvg #8337

Merged
merged 3 commits into from
Jul 15, 2024
Merged

refactor: Add addClass and removeClass methods to blockSvg #8337

merged 3 commits into from
Jul 15, 2024

Conversation

ishon19
Copy link

@ishon19 ishon19 commented Jul 12, 2024 •
edited
Loading

The basics

The details

This PR add addClass and removeClass methods, which accept the class name as a parameter and can be used to perform the dom.addClass call rather than calling it directly.

Fixes #8270

@ishon19 ishon19 requested a review from a team as a code owner July 12, 2024 14:45
@ishon19 ishon19 requested a review from cpcallen July 12, 2024 14:45
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen July 12, 2024 15:58
@BeksOmega BeksOmega assigned BeksOmega and unassigned cpcallen Jul 12, 2024
BeksOmega
BeksOmega requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just some docs nits. Once these are fixed I'll pull your changes down and give them a test.

core/block_svg.ts Outdated Show resolved Hide resolved
core/block_svg.ts Outdated Show resolved Hide resolved
core/block_svg.ts Outdated Show resolved Hide resolved
@ishon19 ishon19 requested a review from BeksOmega July 12, 2024 16:57
BeksOmega
BeksOmega approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Once CI passes I'll get this merged. Thanks for digging into this =)

@ishon19
Copy link
Author

ishon19 commented Jul 15, 2024

This LGTM! Once CI passes I'll get this merged. Thanks for digging into this =)

Thanks @BeksOmega!

@BeksOmega BeksOmega merged commit 7c22c46 into google:rc/v12.0.0 Jul 15, 2024
8 checks passed
@BeksOmega BeksOmega mentioned this pull request Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
PR: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishon19 @BeksOmega @cpcallen