Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove references to getFastTextWidth (#8277) #8307

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix: Remove references to getFastTextWidth (#8277) #8307

merged 2 commits into from
Jul 22, 2024

Conversation

ga-fleury
Copy link

@ga-fleury ga-fleury commented Jul 11, 2024 •
edited by BeksOmega
Loading

Fixes: #8277

feat: Remove references to getFastTextWidth (#8277)

@ga-fleury ga-fleury requested a review from a team as a code owner July 11, 2024 05:13
@ga-fleury ga-fleury requested a review from cpcallen July 11, 2024 05:13
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 11, 2024
@cpcallen cpcallen assigned BeksOmega and unassigned cpcallen Jul 11, 2024
@BeksOmega BeksOmega requested review from BeksOmega and removed request for cpcallen July 11, 2024 17:15
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Jul 11, 2024
BeksOmega
BeksOmega approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fixes =) I'll get this merged once CI passes.

For future peoples: Pulled this down and did some performance profiling, and impacts were minimal. On a 1k Scatter, self-time for getTextWidth was 0.3%.

@BeksOmega
Copy link
Collaborator

Looks like formatting is failing, you can run npm run format and commit the changes to fix it.

BeksOmega
BeksOmega requested changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as changes requested

@BeksOmega
Copy link
Collaborator

Heya @ga-fleury Are you still interested in working on this?

@ga-fleury
Copy link
Author

@BeksOmega format changes commited!

BeksOmega
BeksOmega approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for your work on this!

@BeksOmega BeksOmega changed the title feat: Remove references to getFastTextWidth (#8277) fix: Remove references to getFastTextWidth (#8277) Jul 22, 2024
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: feature Adds a feature labels Jul 22, 2024
@BeksOmega BeksOmega merged commit 58abf6e into google:rc/v12.0.0 Jul 22, 2024
8 checks passed
@BeksOmega BeksOmega mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ga-fleury @BeksOmega @cpcallen