fix: draggable interface and concrete dragger #7967
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes + reasons
This refactors the implementation to match the agreed upon design with two changes:
IDragTarget
objects. I don't know why I did that, since the dragger handles all interaction with drag targets.moveToStart
method that is (essentially) used to cancel a drag in the case that theIDragTarget
returnstrue
forshouldPreventMove
. Before we were just moving the block back to the original coordinates, but that doesn't allow blocks to reattach to parents or children.The agreed upon design has a good separation of concerns between the draggable and the dragger. Giving the draggable responsibility over handling drag targets confuses that, and breaks the single responsibility principle. It also makes it more likely for an external developer to handle the drag targets incorrectly, because there is some fiddliness about the order methods shouldb e called in.
Test Coverage
Manually tested this with following PRs.
Documentation
Yes this will all need docs. May end up happening after the v11 release though =(
Additional Information
N/A