feat: add JSON serialization for workspace comments #7927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
feat/comment-serialization
branch
5 times, most recently
from
b171bea to
b5d1661
Compare
BeksOmega
force-pushed
the
feat/comment-serialization
branch
from
b5d1661 to
d8ffc67
Compare
NeilFraser
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7908
Proposed Changes
Implements a JSON serializer for workspace comments so they can be saved.
Test Coverage
Adds tests for serialization. Deserializing will be covered by round-tripping tests once I fix up the XML system.
Documentation
N/A
Additional Information
N/A