fix: insertion marker previewer finding wrong connection for different conn counts #7833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Feb 5, 2024
BeksOmega
added a commit
that referenced
this pull request
Mar 8, 2024
* fix: destroy connection highlight when the connection is disposed (#7830) * fix: fix reference docs toc generation (#7832) * fix: insertion marker previewer finding wrong connection for different conn counts (#7833) * feat: make grid options togglable (#7828) * chore(deps): Bump prettier from 3.1.1 to 3.2.5 (#7831) Bumps [prettier](https://github.com/prettier/prettier) from 3.1.1 to 3.2.5. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.1.1...3.2.5) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: disposing of connection previewer (#7834) * fix: typo in Click event class docs * chore: rollup of updates from translatewiki for 10.4.0 (#7856) * chore: update metadata for v10.4.0 (#7857) * release: update version number to 10.4.0 * fix: connection previewer disposing too early * Merge pull request #7859 from BeksOmega/fix/previewer-disposing fix: connection previewer disposing too early (cherry picked from commit da3ec25) * release: update version number to 10.4.1 * chore: move connection previewer out of subfolder (#7835) * chore(deps-dev): Bump undici from 5.26.3 to 5.28.3 (#7862) Bumps [undici](https://github.com/nodejs/undici) from 5.26.3 to 5.28.3. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v5.26.3...v5.28.3) --- updated-dependencies: - dependency-name: undici dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update webdriverio to fix chrome endpoint issue (#7875) * fix: insertion marker drag scaling (#7874) * fix: insertion marker drag scaling * chore: added docs for other params * fix: restore respecting snap radius (#7873) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Maribeth Bottorff <maribethb@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elvis Adomnica <elvis.adomnica@gmail.com> Co-authored-by: Rachel Fenichel <fenichel@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes + Reasons
If the insertion marker block had more connections that the original block (e.g. for chameleon blocks) The insertion marker previewer could find the wrong connection and try to connect that.
How chameleon blocks work: If they were connected in a stack, when they start dragging, they add an output connection. Before this change, previews for the previous connection (previously the first connection) would grab the output connection of the insertion marker block (current first connection). This would cause the insertion marker to be positioned incorrectly, because the output couldn't connect where the previous connection is supposed to.
This makes is so that we fail early if the blocks don't match. And that makes the chameleon blocks work.
Test Coverage
Tested by linking with chameleon blocks. No more weird insertion marker positioning bugs.
Documentation
N/A
Additional Information
N/A